From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdB0QIt (ORCPT ); Mon, 27 Feb 2017 11:08:49 -0500 Received: from mail.kernel.org ([198.145.29.136]:56724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbdB0QIq (ORCPT ); Mon, 27 Feb 2017 11:08:46 -0500 Date: Mon, 27 Feb 2017 11:08:41 -0500 From: Steven Rostedt To: Chunyu Hu Cc: mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Fix code comment for ftrace_ops_get_func Message-ID: <20170227110841.12fff548@gandalf.local.home> In-Reply-To: <1487723366-14463-1-git-send-email-chuhu@redhat.com> References: <1487723366-14463-1-git-send-email-chuhu@redhat.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Feb 2017 08:29:26 +0800 Chunyu Hu wrote: > There is no function 'ftrace_ops_recurs_func' existing in the code, it > should be ftrace_ops_assist_func. Fix the comment to avoid misleading. Applied, thanks! I'm not sure it will go in this merge window. It might, I'll have to see what else there is. -- Steve > > Signed-off-by: Chunyu Hu > --- > kernel/trace/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 0c06093..fd84f2e 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip, > * Normally the mcount trampoline will call the ops->func, but there > * are times that it should not. For example, if the ops does not > * have its own recursion protection, then it should call the > - * ftrace_ops_recurs_func() instead. > + * ftrace_ops_assist_func() instead. > * > * Returns the function that the trampoline should call for @ops. > */