From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbdB0RBP (ORCPT ); Mon, 27 Feb 2017 12:01:15 -0500 Received: from mail.kernel.org ([198.145.29.136]:37898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbdB0RBN (ORCPT ); Mon, 27 Feb 2017 12:01:13 -0500 Date: Mon, 27 Feb 2017 11:52:04 -0500 From: "Steven Rostedt (VMware)" To: "Naveen N. Rao" Cc: Masami Hiramatsu , Ananth N Mavinakayanahalli , Ingo Molnar , Michael Ellerman , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 3.5/5] trace/kprobes: Add back warning about offset in return probes Message-ID: <20170227115204.00f92846@gandalf.local.home> In-Reply-To: <20170227113252.05e9c0df@gandalf.local.home> References: <183e7ce2921a08c9c755ee9a5da3134febc6695b.1487770934.git.naveen.n.rao@linux.vnet.ibm.com> <20170227113252.05e9c0df@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's not remove the warning about offsets and return probes when the offset is invalid. Signed-off-by: Steven Rostedt (VMware) --- diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 3f4f788..f626235 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) pr_info("Failed to parse symbol.\n"); return ret; } + if (offset && is_return && + !arch_function_offset_within_entry(offset)) { + pr_info("Given offset is not valid for return probe.\n"); + return -EINVAL; + } } argc -= 2; argv += 2;