From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdB0MBY (ORCPT ); Mon, 27 Feb 2017 07:01:24 -0500 Received: from orbyte.nwl.cc ([151.80.46.58]:35627 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdB0MBW (ORCPT ); Mon, 27 Feb 2017 07:01:22 -0500 Date: Mon, 27 Feb 2017 12:52:18 +0100 From: Phil Sutter To: Jiri Kosina Cc: "David S. Miller" , Stephen Hemminger , Eric Dumazet , Jamal Hadi Salim , Cong Wang , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping Message-ID: <20170227115218.GO6099@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Jiri Kosina , "David S. Miller" , Stephen Hemminger , Eric Dumazet , Jamal Hadi Salim , Cong Wang , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 25, 2017 at 10:29:17PM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > Support the new TCA_DUMP_INVISIBLE netlink attribute that allows asking > kernel to perform 'full qdisc dump', as for historical reasons some of the > default qdiscs are being hidden by the kernel. > > The command syntax is being extended by voluntary 'invisible' argument to > 'tc qdisc show'. > > Signed-off-by: Jiri Kosina > --- > tc/tc_qdisc.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) Would you mind adding a description of the new keyword to tc man page as well? > diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c > index 3a3701c2..29da9269 100644 > --- a/tc/tc_qdisc.c > +++ b/tc/tc_qdisc.c > @@ -34,7 +34,7 @@ static int usage(void) > fprintf(stderr, " [ stab [ help | STAB_OPTIONS] ]\n"); > fprintf(stderr, " [ [ QDISC_KIND ] [ help | OPTIONS ] ]\n"); > fprintf(stderr, "\n"); > - fprintf(stderr, " tc qdisc show [ dev STRING ] [ ingress | clsact ]\n"); > + fprintf(stderr, " tc qdisc show [ dev STRING ] [ ingress | clsact | invisible ]\n"); Doesn't look like these are mutually exclusive. Therefore I would suggest fixing the syntax to: | + fprintf(stderr, " tc qdisc show [ dev STRING ] [ ingress | clsact ] [ invisible ]\n"); Cheers, Phil