From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdB0PYq (ORCPT ); Mon, 27 Feb 2017 10:24:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:46726 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbdB0PYh (ORCPT ); Mon, 27 Feb 2017 10:24:37 -0500 Date: Mon, 27 Feb 2017 16:06:24 +0100 From: Michal Hocko To: Shaohua Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, minchan@kernel.org, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [PATCH V5 5/6] mm: enable MADV_FREE for swapless system Message-ID: <20170227150623.GH26504@dhcp22.suse.cz> References: <155648585589300bfae1d45078e7aebb3d988b87.1487965799.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155648585589300bfae1d45078e7aebb3d988b87.1487965799.git.shli@fb.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 24-02-17 13:31:48, Shaohua Li wrote: > Now MADV_FREE pages can be easily reclaimed even for swapless system. We > can safely enable MADV_FREE for all systems. > > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Hugh Dickins > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Andrew Morton > Acked-by: Johannes Weiner > Signed-off-by: Shaohua Li Acked-by: Michal Hocko > --- > mm/madvise.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 225af7d..5ab4b7b 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -612,13 +612,7 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > case MADV_WILLNEED: > return madvise_willneed(vma, prev, start, end); > case MADV_FREE: > - /* > - * XXX: In this implementation, MADV_FREE works like > - * MADV_DONTNEED on swapless system or full swap. > - */ > - if (get_nr_swap_pages() > 0) > - return madvise_free(vma, prev, start, end); > - /* passthrough */ > + return madvise_free(vma, prev, start, end); > case MADV_DONTNEED: > return madvise_dontneed(vma, prev, start, end); > default: > -- > 2.9.3 > -- Michal Hocko SUSE Labs