From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbdB0Qso (ORCPT ); Mon, 27 Feb 2017 11:48:44 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35091 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbdB0Qsm (ORCPT ); Mon, 27 Feb 2017 11:48:42 -0500 Date: Mon, 27 Feb 2017 17:20:53 +0100 From: Daniel Vetter To: Rob Herring Cc: Benjamin Gaignard , "devicetree@vger.kernel.org" , "linaro-kernel@lists.linaro.org" , Frank Rowand , "linux-kernel@vger.kernel.org" , dri-devel , Vincent Abriou Subject: Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate Message-ID: <20170227162053.j2gca6zmobpengbb@phenom.ffwll.local> Mail-Followup-To: Rob Herring , Benjamin Gaignard , "devicetree@vger.kernel.org" , "linaro-kernel@lists.linaro.org" , Frank Rowand , "linux-kernel@vger.kernel.org" , dri-devel , Vincent Abriou References: <1487952874-23635-1-git-send-email-benjamin.gaignard@linaro.org> <1487952874-23635-2-git-send-email-benjamin.gaignard@linaro.org> <20170226201157.xzg5b5tyrdlxkeyd@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 27, 2017 at 07:30:24AM -0600, Rob Herring wrote: > On Sun, Feb 26, 2017 at 2:11 PM, Daniel Vetter wrote: > > On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote: > >> On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard > >> wrote: > >> > Lots of calls to of_platform_populate() are not unbalanced by a call > >> > to of_platform_depopulate(). This create issues while drivers are > >> > bind/unbind. > >> > > >> > In way to solve those issues is to add devm_of_platform_populate() > >> > which will call of_platform_depopulate() when the device is unbound > >> > from the bus. > >> > > >> > Signed-off-by: Benjamin Gaignard > >> > --- > >> > version 2: > >> > - simplify function prototype to only keep device as parameter > >> > > >> > drivers/of/platform.c | 71 +++++++++++++++++++++++++++++++++++++++++++++ > >> > include/linux/of_platform.h | 11 +++++++ > >> > 2 files changed, 82 insertions(+) > >> > >> For this and patch 2: > >> > >> Acked-by: Rob Herring > > > > Is this an ack for merging both through drm-misc, or should we do a > > topic-branch dance here? > > You can apply it directly. Ok, this seems like a pretty cool idea, so applied both to drm-misc for 4.12. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch