From: Rob Herring <robh@kernel.org>
To: yuantian.tang@nxp.com
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
mark.rutland@arm.com, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Scott Wood <oss@buserror.net>
Subject: Re: [PATCH 1/2] dt-bindings: qoriq-clock: Add coreclk
Date: Mon, 27 Feb 2017 11:18:37 -0600 [thread overview]
Message-ID: <20170227171837.eymnyebgn7ocsp7w@rob-hp-laptop> (raw)
In-Reply-To: <1487137656-4006-1-git-send-email-yuantian.tang@nxp.com>
On Wed, Feb 15, 2017 at 01:47:35PM +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> ls1012a has separate input root clocks for core PLLs versus the platform
> PLL, with the latter described as sysclk in the hw docs.
> Update the qoriq-clock binding to allow a second input clock, named
> "coreclk". If present, this clock will be used for the core PLLs.
>
> Signed-off-by: Scott Wood <oss@buserror.net>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
> Documentation/devicetree/bindings/clock/qoriq-clock.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
The change looks fine, but sounds like Scott should remain the author
(or agree he shouldn't be).
>
> diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> index df9cb5a..97a9666 100644
> --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> @@ -55,6 +55,11 @@ Optional properties:
> - clocks: If clock-frequency is not specified, sysclk may be provided
> as an input clock. Either clock-frequency or clocks must be
> provided.
> + A second input clock, called "coreclk", may be provided if
> + core PLLs are based on a different input clock from the
> + platform PLL.
> +- clock-names: Required if a coreclk is present. Valid names are
> + "sysclk" and "coreclk".
>
> 2. Clock Provider
>
> @@ -71,6 +76,7 @@ second cell is the clock index for the specified type.
> 2 hwaccel index (n in CLKCGnHWACSR)
> 3 fman 0 for fm1, 1 for fm2
> 4 platform pll 0=pll, 1=pll/2, 2=pll/3, 3=pll/4
> + 5 coreclk must be 0
>
> 3. Example
>
> --
> 2.1.0.27.g96db324
>
next prev parent reply other threads:[~2017-02-27 17:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 5:47 yuantian.tang
2017-02-15 5:47 ` [PATCH 2/2] clk: qoriq: Separate root input clock for core PLLs on ls1012a yuantian.tang
2017-02-15 18:36 ` Scott Wood
2017-02-16 2:21 ` Y.T. Tang
2017-02-27 2:19 ` [PATCH 1/2] dt-bindings: qoriq-clock: Add coreclk Y.T. Tang
2017-02-27 17:18 ` Rob Herring [this message]
2017-03-01 1:45 ` Y.T. Tang
2017-03-01 23:17 ` Rob Herring
2017-03-09 8:46 ` Y.T. Tang
2017-07-21 22:03 ` sboyd
2017-07-24 1:20 ` Andy Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227171837.eymnyebgn7ocsp7w@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=oss@buserror.net \
--cc=sboyd@codeaurora.org \
--cc=yuantian.tang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®