From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdB0UpW (ORCPT ); Mon, 27 Feb 2017 15:45:22 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:54650 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbdB0UpL (ORCPT ); Mon, 27 Feb 2017 15:45:11 -0500 From: Arnd Bergmann To: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Hannes Reinecke , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: lpfc: use proper format string for dma_addr_t Date: Mon, 27 Feb 2017 21:37:12 +0100 Message-Id: <20170227203726.3420612-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:wBOId75WXBx0QpxBXKIUb5QBaGxrmJ09kuDHhwni0/EIU1GKZyA 8/qNVQR5DEeUIXd7nPcxROcef2yTfV0ufMeNFe4Ct47JXF/RYBXlX8AROgeTahOYskSXdlT XdoPb4wR7vYDrPW3C3U+t/A+XTHVGN0Y3N5dYjmOmMHLq18JUZ1AkReDF7ZNO0pRtvV6w0U BqNskCqVwUVbeYmTb3GFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:YJP/KX0HV4M=:LjGyxtgbniUVdmcBMusRBg 58LjE3/tmbQMDFoyfpZN4QjyToTsqlYpuP7Iijg0zHO3zHachy719BKIW21l3ZPgUexJicMQb vY4QIvwEiemMnNK0irdlxlxAWPrMaNIS4risa8U6K62YMNNgB5p2UfHEGMEn199VjuvP0tPiY gIsxceaOb+Ie4kC43BsHV2g9AfpAF7k9uAE0gRu7Bz+XeyXhMvZLrGjLOC2S9sxvSmdtoWPAF IMEwwZWnTkZLtTj0ykHr7q+RK0sTGfXLczGdS8A0CbpNZVhwmTolW/QPEXfxLb84Y1ipFpLBJ +Lg3Mc1cWwp3oqEt3p1LrXfWIcnv2B331WP2TZFHlDhNnUY6xN/lZWPa9W98UEBBQwUu2NhMd x/muFnbqfT6mu5jqQ7VyuwYCFoRNO9tnyAFcIiU9omcdkvsVIKUgptP+NYQKmKgfiDjYYoRc3 n/BzUMGW6FOG5asi7p9LuS4f1ldHaOfuEK/NUI1isDkh77/RMmXv+qxDEH4TYmlaO0pXUR+JU zN97wrCaJaWzLvPAwIjnaT29FH/k4ONizl6gGWxkOQGAI10eegRhiJgbAXSRG/tqJ2FY1K6Mw at/wXskGn/lkrPmo4cHoMh4npfPIvaJ595BDmUwn/yNLH5n7M5AIb8ogEIDBJswS3b4BPBzvR hTRzAZk8eCVAcSayv2utoPSlu49NGRGhGazesmEsZ3ML5LHh0/a+1IeZdQF/1XHQGXKM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma_addr_t may be either u32 or u64, depending on the kernel configuration, and we get a warning for the 32-bit case: drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_req': drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 12 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_abort': drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 12 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] printk has a special "%pad" format string that passes the dma address by reference to solve this problem. Fixes: 01649561a8b4 ("scsi: lpfc: NVME Initiator: bind to nvme_fc api") Signed-off-by: Arnd Bergmann --- drivers/scsi/lpfc/lpfc_nvme.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 625b6589a34d..609a908ea9db 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/drivers/scsi/lpfc/lpfc_nvme.c @@ -457,11 +457,11 @@ lpfc_nvme_ls_req(struct nvme_fc_local_port *pnvme_lport, /* Expand print to include key fields. */ lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_DISC, "6051 ENTER. lport %p, rport %p lsreq%p rqstlen:%d " - "rsplen:%d %llux %llux\n", + "rsplen:%d %pad %pad\n", pnvme_lport, pnvme_rport, pnvme_lsreq, pnvme_lsreq->rqstlen, - pnvme_lsreq->rsplen, pnvme_lsreq->rqstdma, - pnvme_lsreq->rspdma); + pnvme_lsreq->rsplen, &pnvme_lsreq->rqstdma, + &pnvme_lsreq->rspdma); vport->phba->fc4NvmeLsRequests++; @@ -527,11 +527,11 @@ lpfc_nvme_ls_abort(struct nvme_fc_local_port *pnvme_lport, /* Expand print to include key fields. */ lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_ABTS, "6040 ENTER. lport %p, rport %p lsreq %p rqstlen:%d " - "rsplen:%d %llux %llux\n", + "rsplen:%d %pad %pad\n", pnvme_lport, pnvme_rport, pnvme_lsreq, pnvme_lsreq->rqstlen, - pnvme_lsreq->rsplen, pnvme_lsreq->rqstdma, - pnvme_lsreq->rspdma); + pnvme_lsreq->rsplen, &pnvme_lsreq->rqstdma, + &pnvme_lsreq->rspdma); /* * Lock the ELS ring txcmplq and build a local list of all ELS IOs -- 2.9.0