From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751867AbdB0WTc (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Feb 2017 17:19:32 -0500
Received: from mail-wr0-f179.google.com ([209.85.128.179]:34245 "EHLO
        mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751586AbdB0WT1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Feb 2017 17:19:27 -0500
Date: Mon, 27 Feb 2017 22:06:39 +0100
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Mika =?iso-8859-1?Q?Penttil=E4?= <mika.penttila@nextfour.com>,
        LKML <linux-kernel@vger.kernel.org>, linus.walleij@linaro.org
Subject: Re: [REGRESSION] pinctrl, of, unable to find hogs
Message-ID: <20170227210639.pxkcafpitacb6uwj@t450s.lan>
References: <4b93bdb8-2894-4c27-6256-21499110f08e@nextfour.com>
 <20170227155352.GL21809@atomide.com>
 <20170227162747.kxgkyqzjximtou4u@t450s.lan>
 <20170227164033.3ogiyrt2hqlsnfqn@t450s.lan>
 <20170227173718.GO21809@atomide.com>
 <20170227184535.GP21809@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170227184535.GP21809@atomide.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,

On Mon, Feb 27, 2017 at 10:45:35AM -0800, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [170227 09:37]:
> > * Gary Bisson <gary.bisson@boundarydevices.com> [170227 08:42]:
> > > > Not sure how to fix it though since we can't move the dt probing before
> > > > radix tree init.
> > 
> > Yup looks like we still have an issue with pinctrl driver functions
> > getting called before driver probe has completed.
> > 
> > How about we introduce something like:
> > 
> > int pinctrl_claim_hogs(struct pinctrl_dev *pctldev);
> > 
> > Then the drivers can call that at the end of the probe after
> > the pins have been parsed?
> > 
> > This should be safe as no other driver can claim the pins either
> > before the pins have been parsed :)
> 
> Below is an initial take on this solution. I've only briefly tested
> it so far but maybe give it a try and see if it helps.
> 
> I'll take a look if we can make the error handling better for
> pinctrl_register_and_init().

I'll try that tomorrow morning and let you know.

Regards,
Gary