From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751654AbdB0SGe (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Feb 2017 13:06:34 -0500
Received: from mail.kernel.org ([198.145.29.136]:47148 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751344AbdB0SGN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Feb 2017 13:06:13 -0500
Date: Tue, 28 Feb 2017 01:11:40 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: kernel test robot <xiaolong.ye@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexander Potapenko <glider@google.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Tobias Regnery <tobias.regnery@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>, <lkp@01.org>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [lkp-robot] [x86/mm/ptdump] 243b72aae2:
 WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page
Message-Id: <20170228011140.ef61008afb57976a74ead279@kernel.org>
In-Reply-To: <34aa4f8e-190a-8895-bf43-22d3f08efd17@virtuozzo.com>
References: <20170227010341.GA32284@yexl-desktop>
        <34aa4f8e-190a-8895-bf43-22d3f08efd17@virtuozzo.com>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Feb 2017 16:01:34 +0300
Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:

> On 02/27/2017 04:03 AM, kernel test robot wrote:
> > 
> > FYI, we noticed the following commit:
> > 
> > commit: 243b72aae28ca1032284028323bb81c9235b15c9 ("x86/mm/ptdump: Optimize check for W+X mappings for CONFIG_KASAN=y")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> ...
> > 
> > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> > 
> > 
> > +-----------------------------------------------------+------------+------------+
> > |                                                     | 5b1ad68f9b | 243b72aae2 |
> > +-----------------------------------------------------+------------+------------+
> > | boot_successes                                      | 0          | 0          |
> > | boot_failures                                       | 8          | 6          |
> > | BUG:KASAN:slab-out-of-bounds                        | 8          | 6          |
> > | WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page | 0          | 6          |
> > +-----------------------------------------------------+------------+------------+
> 
> Ok, I reproduced this, but it's definitely caused *not* by 243b72aae28.
> This WARN is also reproducible on the parent commit 5b1ad68f9b.
> The only difference here is that on parent one needs dozens of seconds to reach this WARNING.
> It seems that this time difference somehow confused the robot.
> 
> As for the warning itself, it caused by kprobes. krpobe code use module_alloc() which
> creates these RWX mappings.
> I'm not sure how to fix this as AFAIK kprobes actually need RWX mapping.

Thanks! I also noticed this issue. I actually have a plan to make kprobes with R+X mappings (as ftrace does).
I'll queue this on my TODO list.



-- 
Masami Hiramatsu <mhiramat@kernel.org>