From: Peter Zijlstra <peterz@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Omar Sandoval <osandov@osandov.com>
Subject: Re: [PATCH 0/4] blk-mq: cleanup on all kinds of kobjects
Date: Tue, 28 Feb 2017 10:46:43 +0100 [thread overview]
Message-ID: <20170228094643.GE6557@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1487758442-5855-1-git-send-email-tom.leiming@gmail.com>
On Wed, Feb 22, 2017 at 06:13:58PM +0800, Ming Lei wrote:
> This patchset cleans up on kojects of request_queue.mq_kobj,
> sw queue's kobject and hw queue's kobject.
>
> The 1st patch initialized kobject of request_queue and sw queue
> in blk_mq_init_allocated_queue(), so we can avoid to initialize
> these kobjects several times, and this patch fixes one kerne
> warning reported from Omar Sandoval.
>
> The 2nd patch makes lifetime consitent between mq request queue/sw
> queue and their kobjects.
>
> The 3rd patch makes lifetime consitent between hw queue and their
> kobjects.
>
> The last patch is a followup of 3rd patch.
These do indeed make the kobject warnings, and the resulting refcount
warning, go away.
Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
next prev parent reply other threads:[~2017-02-28 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 10:13 Ming Lei
2017-02-22 10:13 ` [PATCH 1/4] blk-mq: initialize mq kobjects in blk_mq_init_allocated_queue() Ming Lei
2017-02-22 10:14 ` [PATCH 2/4] blk-mq: make lifetime consitent between q/ctx and its kobject Ming Lei
2017-02-22 10:14 ` [PATCH 3/4] blk-mq: make lifetime consistent between hctx " Ming Lei
2017-02-22 10:14 ` [PATCH 4/4] blk-mq: free hctx->cpumask in release handler of hctx's kobject Ming Lei
2017-02-28 9:46 ` Peter Zijlstra [this message]
2017-03-03 15:34 ` [PATCH 0/4] blk-mq: cleanup on all kinds of kobjects Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228094643.GE6557@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®