From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752154AbdB1Js5 (ORCPT ); Tue, 28 Feb 2017 04:48:57 -0500 Received: from merlin.infradead.org ([205.233.59.134]:57500 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdB1Jsz (ORCPT ); Tue, 28 Feb 2017 04:48:55 -0500 Date: Tue, 28 Feb 2017 10:48:53 +0100 From: Peter Zijlstra To: Chris Wilson Cc: linux-kernel@vger.kernel.org, Fengguang Wu Subject: Re: [PATCH] locking/ww_mutex: Replace cpu_relax with cond_resched for tests Message-ID: <20170228094853.GF6500@twins.programming.kicks-ass.net> References: <20170228035924.hqckycv6at4sfzyc@wfg-t540p.sh.intel.com> <20170228094011.2595-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170228094011.2595-1-chris@chris-wilson.co.uk> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 09:40:11AM +0000, Chris Wilson wrote: > When busy-spinning on a ww_mutex_trylock(), we depend upon the other > thread advancing and releasing the lock. This can not happen on a single > CPU unless we relinquish it. Thanks, do you have any clue about those other ww-mutex test fails? So far I've not had much luck poking at them.