From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbdB1MhY (ORCPT ); Tue, 28 Feb 2017 07:37:24 -0500 Received: from dougal.metanate.com ([90.155.101.14]:51453 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751737AbdB1MhW (ORCPT ); Tue, 28 Feb 2017 07:37:22 -0500 From: John Keeping To: Felipe Balbi Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, John Keeping Subject: [PATCH] usb: gadget: configs: plug memory leak Date: Tue, 28 Feb 2017 10:55:30 +0000 Message-Id: <20170228105530.5485-1-john@metanate.com> X-Mailer: git-send-email 2.12.0.rc2.230.ga28edc07cd.dirty Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When binding a gadget to a device, "name" is stored in gi->udc_name, but this does not happen when unregistering and the string is leaked. Signed-off-by: John Keeping --- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c index 78c44979dde3..cbff3b02840d 100644 --- a/drivers/usb/gadget/configfs.c +++ b/drivers/usb/gadget/configfs.c @@ -269,6 +269,7 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item, ret = unregister_gadget(gi); if (ret) goto err; + kfree(name); } else { if (gi->composite.gadget_driver.udc_name) { ret = -EBUSY; -- 2.12.0.rc2.230.ga28edc07cd.dirty