From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbdB1LjE (ORCPT ); Tue, 28 Feb 2017 06:39:04 -0500 Received: from foss.arm.com ([217.140.101.70]:36390 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdB1LjD (ORCPT ); Tue, 28 Feb 2017 06:39:03 -0500 Date: Tue, 28 Feb 2017 11:15:37 +0000 From: Juri Lelli To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] sched: deadline: Fix confusing comments about selection of top pi-waiter Message-ID: <20170228111537.GL19665@e106622-lin> References: <20170223040916.8820-1-joelaf@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170223040916.8820-1-joelaf@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 22/02/17 20:09, Joel Fernandes wrote: > This comment in the code is incomplete, and I believe it begs a definition of > dl_boosted to make sense of the condition that follows. Rewrite the comment and > also rearrange the condition that follows to reflect the first condition "we > have a top pi-waiter which is a SCHED_DEADLINE task" in that order. Also fix a > typo that follows. > > Cc: Juri Lelli > Signed-off-by: Joel Fernandes Looks good to me. Acked-by: Juri Lelli Thanks, - Juri