From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbdB1L7A (ORCPT ); Tue, 28 Feb 2017 06:59:00 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:47038 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752096AbdB1L67 (ORCPT ); Tue, 28 Feb 2017 06:58:59 -0500 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Tue, 28 Feb 2017 12:33:39 +0000 Date: Tue, 28 Feb 2017 11:29:03 +0000 From: James Hogan To: David Hildenbrand CC: Andrew Jones , Radim =?utf-8?B?S3LEjW3DocWZ?= , , , Paolo Bonzini , Marc Zyngier , Christian Borntraeger , Cornelia Huck , Paul Mackerras , Christoffer Dall Subject: Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Message-ID: <20170228112903.GK996@jhogan-linux.le.imgtec.org> References: <20170224195002.28030-1-rkrcmar@redhat.com> <20170224195002.28030-5-rkrcmar@redhat.com> <20170227084539.oq3uviixwsjtmpdj@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7AwgMNpd3VkAVXjS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: 1b7d744b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7AwgMNpd3VkAVXjS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote: > Am 27.02.2017 um 09:45 schrieb Andrew Jones: > > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > >> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > >> --- > >> arch/mips/kvm/emulate.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c > >> index 552ae2b5e911..70614ca41744 100644 > >> --- a/arch/mips/kvm/emulate.c > >> +++ b/arch/mips/kvm/emulate.c > >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kv= m_vcpu *vcpu) > >> * check if any I/O interrupts are pending. > >> */ > >> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) { > >> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu); > >> vcpu->run->exit_reason =3D KVM_EXIT_IRQ_WINDOW_OPEN; > >> } > >=20 > > should remove the {} too. > >=20 >=20 > With that, >=20 > Reviewed-by: David Hildenbrand and with that: Acked-by: James Hogan Cheers James --7AwgMNpd3VkAVXjS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYtV7zAAoJEGwLaZPeOHZ6OSMP/2XV98gwn9dEWVpUvHrOBFVb t8hkcxnb4qCA/HvkeE9HO7rtddvR2cJA59vfP3R1kjFkpu+TyqaoJIbGCFlInHTl 4KqJ+obAeZJdGuxVXmpcFcLJOalY6z2cznImo+4TAQmFUj4TUj9Bm29PcuodSxT4 5sWi7iNw27fjbkkHvPW9x0Xcs54uGzxRMLPEwm3TNBUQF0Rf8M+uV7QVu21DXCRM 8cckbIjOZYwtnGqVwkv6FkrbPYw4JoWtsdh38YaqmNnJGZF5aw9kRt8uygYvUSp7 XH9/m8RYNTaojnSVE2ZTXyDCswG1WdUZV2dVffActd777q3c7bJRq3G7/6nKUDlb vp1Qg4vC4hK+x8/3jhOEE5T7/FK1DRW1RXs1cbh9UfS3jsJHB0titsb4lKHax/9Y MdUivTOBpD+P9EwBXqryspE3gHg1HYQgq8VZIDHkwzRPrr9KpBhgF0XkfmaO6u/4 GZegJxQTnKqNCsmX7ca9hK05pF5uP5ZjGJUFXHP3L9F1rR/A/wi5Mjwy62CTLfLA upUdeNmCXGQgIkOPzEgGepW44XZt9Ze24GL6l3ClOcCK/wNgN/UyREGM3ms6AkxJ X+wU6g2woNavI62iBtgQHbQ8+VRjIWjU2y7Mvtq6loB5NwSb7M82bq//61GVhFru rmb1ifBaXqaLB36QQAXJ =U1qG -----END PGP SIGNATURE----- --7AwgMNpd3VkAVXjS--