From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751451AbdB1SRd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 13:17:33 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:40580 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751334AbdB1SRc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 13:17:32 -0500
Date: Tue, 28 Feb 2017 18:53:17 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Sumantro <saggy.zone@gmail.com>
Cc: devel@driverdev.osuosl.org, vishali.thakkar@oracle.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from
 crtl_wx.c
Message-ID: <20170228175317.GA14128@kroah.com>
References: <20170228144625.GA18416@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170228144625.GA18416@localhost.localdomain>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 28, 2017 at 08:16:25PM +0530, Sumantro wrote:
> staging:rtl8192e: removed extra whitelines which were giving warnings 
> Signed-off-by: Sumantro <saggy.zone@gmail.com>

We need a blank line before the signed-off-by line, as well as a
"real/full" name being used (unless you use only "Sumantro" on legal
documents.)

Also, you need to be a bit more verbose in the changelog text, no need
to repeat the driver and subsystem name, it's up there in the subject
line.

Look at other patches for the driver for examples of what needs to be
done here.

thanks,

greg k-h