From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdB1Sor (ORCPT ); Tue, 28 Feb 2017 13:44:47 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:35229 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbdB1SnS (ORCPT ); Tue, 28 Feb 2017 13:43:18 -0500 Date: Tue, 28 Feb 2017 10:43:14 -0800 From: Guenter Roeck To: Randy Dunlap Cc: linux-watchdog@vger.kernel.org, LKML , Wim Van Sebroeck , Michael Brunner Subject: Re: [PATCH -next] watchdog/kempld_wdt: fix build for COMPILE_TEST Message-ID: <20170228184314.GA5589@roeck-us.net> References: <00718dc0-2a7c-391d-a091-c79e192dbeb2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00718dc0-2a7c-391d-a091-c79e192dbeb2@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 10:31:07AM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kconfig dependencies when COMPILE_TEST is enabled so that > interdependent module dependencies are configured as needed. > > Fixes build when MFD_KEMPLD=m and KEMPLD_WDT=y and COMPILE_TEST=y. > The problem is in mixing tristate and boolean dependencies. > > This fixes 32 build errors like these (most are omitted here): > drivers/built-in.o: In function `kempld_wdt_stop': > kempld_wdt.c:(.text+0x19ab8d): undefined reference to `kempld_get_mutex' > kempld_wdt.c:(.text+0x19ab99): undefined reference to `kempld_read8' > kempld_wdt.c:(.text+0x19abaa): undefined reference to `kempld_write8' > kempld_wdt.c:(.text+0x19abbf): undefined reference to `kempld_release_mutex' > drivers/built-in.o: In function `kempld_wdt_keepalive': > kempld_wdt.c:(.text+0x19ac24): undefined reference to `kempld_release_mutex' > drivers/built-in.o: In function `kempld_wdt_set_stage_action.isra.4': > kempld_wdt.c:(.text+0x19aca1): undefined reference to `kempld_get_mutex' > drivers/built-in.o: In function `kempld_wdt_set_stage_timeout.isra.5': > kempld_wdt.c:(.text+0x19adde): undefined reference to `kempld_release_mutex' > drivers/built-in.o: In function `kempld_wdt_start': > kempld_wdt.c:(.text+0x19ae89): undefined reference to `kempld_get_mutex' > drivers/built-in.o: In function `kempld_wdt_get_timeout.isra.6': > kempld_wdt.c:(.text+0x19b01a): undefined reference to `kempld_read8' > drivers/built-in.o: In function `kempld_wdt_update_timeouts': > kempld_wdt.c:(.text+0x19b0c6): undefined reference to `kempld_get_mutex' > drivers/built-in.o: In function `kempld_wdt_suspend': > kempld_wdt.c:(.text+0x19b136): undefined reference to `kempld_release_mutex' > drivers/built-in.o: In function `kempld_wdt_probe': > kempld_wdt.c:(.text+0x19b1a4): undefined reference to `kempld_get_mutex' > kempld_wdt.c:(.text+0x19b1bd): undefined reference to `kempld_release_mutex' > > Signed-off-by: Randy Dunlap > Cc: Michael Brunner And I thought I had that all sorted out :-( Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20170228.orig/drivers/watchdog/Kconfig > +++ linux-next-20170228/drivers/watchdog/Kconfig > @@ -1063,7 +1063,7 @@ config HP_WATCHDOG > > config KEMPLD_WDT > tristate "Kontron COM Watchdog Timer" > - depends on MFD_KEMPLD || COMPILE_TEST > + depends on MFD_KEMPLD || (MFD_KEMPLD=y && COMPILE_TEST) > select WATCHDOG_CORE > help > Support for the PLD watchdog on some Kontron ETX and COMexpress