From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbdB1Soq (ORCPT ); Tue, 28 Feb 2017 13:44:46 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:34504 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbdB1Sni (ORCPT ); Tue, 28 Feb 2017 13:43:38 -0500 Date: Tue, 28 Feb 2017 10:43:35 -0800 From: Guenter Roeck To: Randy Dunlap Cc: linux-watchdog@vger.kernel.org, LKML , Wim Van Sebroeck , Mark Brown , patches@opensource.wolfsonmicro.com Subject: Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled Message-ID: <20170228184335.GB5589@roeck-us.net> References: <8bb4874f-7d0e-225f-3a97-842c2d171c78@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bb4874f-7d0e-225f-3a97-842c2d171c78@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 10:31:15AM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kconfig dependencies when COMPILE_TEST is enabled so that > interdependent module dependencies are configured as needed. > > Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y. > No other WM831X drivers are enabled. > The problem is in mixing tristate and boolean dependencies. > > ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined! > ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined! > ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined! > ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined! > ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined! > > Signed-off-by: Randy Dunlap > Cc: patches@opensource.wolfsonmicro.com > Cc: Mark Brown Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20170228.orig/drivers/watchdog/Kconfig > +++ linux-next-20170228/drivers/watchdog/Kconfig > @@ -176,7 +176,7 @@ config WDAT_WDT > > config WM831X_WATCHDOG > tristate "WM831x watchdog" > - depends on MFD_WM831X || COMPILE_TEST > + depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST) > select WATCHDOG_CORE > help > Support for the watchdog in the WM831x AudioPlus PMICs. When