From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751930AbdB1TgO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 14:36:14 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:47592 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751519AbdB1Tfy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 14:35:54 -0500
Date: Tue, 28 Feb 2017 20:26:19 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Chetan Sethi <cpsethi369@gmail.com>
Cc: devel@driverdev.osuosl.org, punitvara@gmail.com, wsa@the-dreams.de,
        linux-kernel@vger.kernel.org, shiva@exdev.nl
Subject: Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line
 over 80 characters
Message-ID: <20170228192619.GB22709@kroah.com>
References: <20170227144627.GA24022@kroah.com>
 <1488250776-5602-1-git-send-email-cpsethi369@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1488250776-5602-1-git-send-email-cpsethi369@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote:
> This patch fixes warning of line over 80 characters, as issued by
> checkpatch.pl
> 
> Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
> ---
> v2:
>  - split multiple changes across different patches
> v3:
>  - mentioned patch revision in subject
> v4:
>  - modified description to exclude mention of patch number from changelog
> v5:
>  - updated series for removing additional checkpatch error introduced
> 
>  drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 9ab80e1..668202d 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -18,10 +18,10 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  
> -#include <linux/spinlock.h>	/* spinlock_t                                   */
> -#include <linux/sched.h>	/* wait_queue_head_t                            */
> -#include <linux/types.h>	/* pid_t                                        */
> -#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
> +#include <linux/spinlock.h>	/* spinlock_t */
> +#include <linux/sched.h>	/* wait_queue_head_t */
> +#include <linux/types.h>	/* pid_t */
> +#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
>  #include <linux/etherdevice.h>
>  #include <linux/wireless.h>
>  #include <linux/atomic.h>	/* struct atomic_t */
> @@ -36,7 +36,8 @@
>  
>  #ifdef KS_WLAN_DEBUG
>  #define DPRINTK(n, fmt, args...) \
> -                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> +                 if (KS_WLAN_DEBUG > (n)) \

Why did you not use a tab here to indent this line as you were modifying
it?

thanks,

greg k-h