From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbdB1Viz (ORCPT ); Tue, 28 Feb 2017 16:38:55 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:44808 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbdB1Vix (ORCPT ); Tue, 28 Feb 2017 16:38:53 -0500 Date: Tue, 28 Feb 2017 13:36:14 -0800 From: Guenter Roeck To: Arnd Bergmann Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Message-ID: <20170228213614.GB6651@roeck-us.net> References: <20170228210123.3404816-1-arnd@arndb.de> <20170228210123.3404816-4-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170228210123.3404816-4-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 10:01:18PM +0100, Arnd Bergmann wrote: > The wm831x watchdog driver can now be built without the wm831x mfd > driver, which results in a link error: > > (.text+0x1a95c): undefined reference to `wm831x_set_bits' > (.text+0x1a95c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `wm831x_set_bits' > (.text+0x1a968): undefined reference to `wm831x_reg_lock' > (.text+0x1a968): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `wm831x_reg_lock' > (.text+0x1a9dc): undefined reference to `wm831x_reg_unlock' > (.text+0x1a9dc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `wm831x_reg_unlock' > > This adds back the dependency that was removed. We can still build test > this driver on all architectures by enabling the MFD driver for it first. > > Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") > Signed-off-by: Arnd Bergmann > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 6ca2f3ae7f1e..34a927703d64 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -176,7 +176,7 @@ config WDAT_WDT > > config WM831X_WATCHDOG > tristate "WM831x watchdog" > - depends on MFD_WM831X || COMPILE_TEST > + depends on MFD_WM831X I prefer the fix proposed by Randy: - depends on MFD_WM831X || COMPILE_TEST + depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST) > select WATCHDOG_CORE > help > Support for the watchdog in the WM831x AudioPlus PMICs. When > -- > 2.9.0 >