From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607AbdCAA35 (ORCPT ); Tue, 28 Feb 2017 19:29:57 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:50333 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbdCAA3z (ORCPT ); Tue, 28 Feb 2017 19:29:55 -0500 Date: Tue, 28 Feb 2017 15:19:30 -0800 From: Guenter Roeck To: Arnd Bergmann Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Lee Jones , Linux Kernel Mailing List Subject: Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Message-ID: <20170228231930.GA10193@roeck-us.net> References: <20170228210123.3404816-1-arnd@arndb.de> <20170228210123.3404816-3-arnd@arndb.de> <20170228214203.GE6651@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 10:47:02PM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 10:42 PM, Guenter Roeck wrote: > > On Tue, Feb 28, 2017 at 10:01:17PM +0100, Arnd Bergmann wrote: > >> When the db8500 watchdog is enabled without the PRCMU, we get a lot of > >> warnings about duplicate or missing helper functions: > >> > >> In file included from drivers/watchdog/ux500_wdt.c:21:0: > >> include/linux/mfd/dbx500-prcmu.h:422:19: error: redefinition of 'prcmu_abb_read' > >> static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size) > >> > >> This removes the duplicate function definitions and moves the helpers in > >> dbx500-prcmu outside of the #ifdef that hides them. > >> > > > > Is that appropriate ? Maybe we should just disable COMPILE_TEST > > for this driver instead. > > Or we could do both. The MFD driver was written to support this in principle, > it just hasn't worked in a long time. > Both sounds better to me at this point. Guenter