mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Clark Williams <williams@redhat.com>,
	Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH v2] sched/rt: Add comments describing the RT IPI pull method
Date: Wed, 1 Mar 2017 10:44:09 +0100	[thread overview]
Message-ID: <20170301094409.GB6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170228155030.30c69068@gandalf.local.home>

On Tue, Feb 28, 2017 at 03:50:30PM -0500, Steven Rostedt wrote:
> + * The overloaded RT CPU, wher receiving an IPI, will try to push off its

"wher" isn't in my dictionary, I'm thinking you mean: "when". Fixed that
for you.

> + * overloaded RT tasks and then send an IPI to the next CPU that has
> + * overloaded RT tasks. This stops when all CPUs with overloaded RT tasks
> + * have completed. Just because a CPU may have pushed off its own overloaded
> + * RT task does not mean it should stop sending the IPI around to other
> + * overloaded CPUs. There may be another RT task waiting to run on one of
> + * those CPUs that are of higher priority than the one that was just
> + * pushed.
> + *
> + * An optimization that could possibly be made is to make a CPU array similar
> + * to the cpupri array mask of all running RT tasks, but for the overloaded
> + * case, then the IPI could be sent to only the CPU with the highest priority
> + * RT task waiting, and that CPU could send off further IPIs to the CPU with
> + * the next highest waiting task. Since the overloaded case is much less likely
> + * to happen, the complexity of this implementation may not be worth it.
> + * Instead, just send an IPI around to all overloaded CPUs.

Yeah, not sure, I'll leave it in though.

  reply	other threads:[~2017-03-01  9:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 20:50 Steven Rostedt
2017-03-01  9:44 ` Peter Zijlstra [this message]
2017-03-01 13:40   ` Steven Rostedt
2017-03-16 11:16 ` [tip:sched/core] " tip-bot for Steven Rostedt (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170301094409.GB6515@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=bristot@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®