From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbdCAK1A (ORCPT ); Wed, 1 Mar 2017 05:27:00 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:37861 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbdCAK0k (ORCPT ); Wed, 1 Mar 2017 05:26:40 -0500 Date: Wed, 1 Mar 2017 11:14:56 +0100 From: Maxime Ripard To: Icenowy Zheng Cc: Zhang Rui , linux-pm@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ondrej Jirman , Eduardo Valentin , linux-arm-kernel@lists.infradead.org, Chen-Yu Tsai Subject: Re: [PATCH 2/3] thermal: add support for the thermal sensor on Allwinner new SoCs Message-ID: <20170301101456.a745eghkjoz5zzk7@lukather> References: <20170301054835.mUDm4hZv@smtp2m.mail.yandex.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3bewbit4du2nboip" Content-Disposition: inline In-Reply-To: <20170301054835.mUDm4hZv@smtp2m.mail.yandex.net> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3bewbit4du2nboip Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2017 at 03:18:13PM +0800, Icenowy Zheng wrote: >=20 > 2017=E5=B9=B42=E6=9C=8828=E6=97=A5 14:44=E4=BA=8E Maxime Ripard =E5=86=99=E9=81=93=EF=BC=9A > > > > On Tue, Feb 28, 2017 at 03:40:53AM +0800, Icenowy Zheng wrote:=20 > > > From: Ondrej Jirman =20 > > >=20 > > > Allwinner SoCs from H3 (including H5, A64, etc) have a new version of= =20 > > > thermal sensor, and needs a new driver for it.=20 > > >=20 > > > Add such a driver.=20 > > >=20 > > > Currently only H3 is supported, but other SoCs are easily to be=20 > > > supported by adding new formula and set the sensor number.=20 > > >=20 > > > Signed-off-by: Ond=C5=99ej Jirman =20 > > > [Icenowy: extend to support further multiple-sensor SoCs, change comm= it=20 > > >=C2=A0 message]=20 > > > Signed-off-by: Icenowy Zheng =20 > > > > There's no need to create a new driver for that. This can be handled=20 > > by the GPADC driver we already have.=20 >=20 > sun8i-ths is not GPADC at all. >=20 > The latest SoC I know that use GPADC as thermal sensor is A33. It's not called the same way, but it definitely is an evolution of the same controller. There's no need for a new driver, only reworking what is already there. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --3bewbit4du2nboip Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYtp8cAAoJEBx+YmzsjxAgZ0IP/0HAvNHaPhYU2o10C+Ls/ofn 6sTvk875Hba8mgND/7hQ4VJJ4aGqXHamXDZ4DtMyHtpgySBLBvM3MLg2cgPJzO0T eFRMQUO8al5P/kuBzpOtNXwYCfZfmPqTBXGTg06wbk90MG0IMXWdaAhSFnU41Ub0 d/Y9lyW/vf1vRurcioHc8obsbLxn/ZVOoP4Ic/ivZTUaJrfpmoqxjrx4T1VGajgJ MHOS8G1CuW9LgTGB5PIhqQHO2x7htWFQujJJ+gBI2cP0NYEdFuB6HMiydHC4/Ni6 KqeAgbNnL9wZKDPJTvznBaOvjSWsOijjnLlSh2y947seG5xW4thY1VjtqhG225Df +C8QbfZQnYJn73TB9lHAlGpKWuxc5DwDbnYTDfGdkLz1yyOWXjF1az/7kYdcCq1Y R/pjwe4Wg3K+fiO6SdnXcwMisIBEKg7bakt++IqQje3j3TH2uc1F5uuyCWMlizh+ WStd+dKpTDM1kAOFFgXo0XnKCtb2LFnD8DpYsO0J4vXv1l7ozMRwKUwi1cC3XChx POWSOWeIrnmnitGrWeD8ZCErdrF69aYGR+/xZqWASTTkwXEV1JDLtyBDscmeBiyM VcwQBir/aBn5aAHSF2gK5+RH4KJU3Ewx0ltg+Hw+T4wwNgPK9K2VrnIIjFkr/3M7 XG4kQrW5SJB50VNfnY+c =bvLQ -----END PGP SIGNATURE----- --3bewbit4du2nboip--