From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbdCAKeQ (ORCPT ); Wed, 1 Mar 2017 05:34:16 -0500 Received: from mga14.intel.com ([192.55.52.115]:24622 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdCAKby (ORCPT ); Wed, 1 Mar 2017 05:31:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,225,1484035200"; d="scan'208";a="1116996707" Date: Wed, 1 Mar 2017 18:30:19 +0800 From: kbuild test robot To: Alan Cox Cc: kbuild-all@01.org, devel@driverdev.osuosl.org, Greg Kroah-Hartman , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging/atomisp: fix returnvar.cocci warnings Message-ID: <20170301103019.GA31464@lkp-wsm-ep1> References: <201703011837.1R4zsbQi%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201703011837.1R4zsbQi%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c:560:5-8: Unneeded variable: "ret". Return "0" on line 577 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Alan Cox Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! atomisp_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c @@ -557,8 +557,6 @@ const struct atomisp_format_bridge *atom static int atomisp_querycap(struct file *file, void *fh, struct v4l2_capability *cap) { - int ret = 0; - memset(cap, 0, sizeof(struct v4l2_capability)); WARN_ON(sizeof(DRIVER) > sizeof(cap->driver) || @@ -574,7 +572,7 @@ static int atomisp_querycap(struct file cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_OUTPUT; cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; - return ret; + return 0; } /*