From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754508AbdCBJRg (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Mar 2017 04:17:36 -0500
Received: from mga05.intel.com ([192.55.52.43]:21574 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754466AbdCBJRJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Mar 2017 04:17:09 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,230,1484035200"; 
   d="scan'208";a="231391694"
Date: Thu, 2 Mar 2017 11:17:04 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Marcel Selhorst <tpmdd@selhorst.net>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        Christophe Ricard <christophe.ricard@gmail.com>,
        Nayna Jain <nayna@linux.vnet.ibm.com>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO
Message-ID: <20170302091704.wuxhmhqrj7xe4e2j@intel.com>
References: <20170228211326.3667625-1-arnd@arndb.de>
 <A83F6A3E-1BE9-48C9-8FB8-B3C061402061@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A83F6A3E-1BE9-48C9-8FB8-B3C061402061@gmx.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.6.2-neo (2016-08-21)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote:
> 
> 
> Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@arndb.de>:
> >We get a newly introduced harmless warning when CONFIG_CRYPTO is
> >disabled:
> >
> >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
> >which has unmet direct dependencies (CRYPTO)
> >
> >This adds another select to avoid the warning, consistent with other
> >users
> >of the crypto code.
> >
> >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
> >multiple banks")
> >Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Lgtm
> 
> Reviewed-by: Peter Huewe <peterhuewe@gmx.de>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> >---
> > drivers/char/tpm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> >index af985cca413c..d520ac51c11c 100644
> >--- a/drivers/char/tpm/Kconfig
> >+++ b/drivers/char/tpm/Kconfig
> >@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> > 	tristate "TPM Hardware Support"
> > 	depends on HAS_IOMEM
> > 	select SECURITYFS
> >+	select CRYPTO
> > 	select CRYPTO_HASH_INFO
> > 	---help---
> > 	  If you have a TPM security chip in your system, which
> 
> -- 
> Sent from my mobile