From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbdCBNJc (ORCPT ); Thu, 2 Mar 2017 08:09:32 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33858 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbdCBNJb (ORCPT ); Thu, 2 Mar 2017 08:09:31 -0500 Date: Thu, 2 Mar 2017 18:30:50 +0530 From: simran singhal To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sergio.paracuellos@gmail.com, juliana.orod@gmail.com, thomas.petazzoni@free-electrons.com, noralf@tronnes.org, outreachy-kernel@googlegroups.com Subject: [PATCH v2 3/6] staging: wlan-ng: Fix sparse warnings in hfa384x_usb.c Message-ID: <20170302130050.GA28609@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following sparse warnings: drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: expected unsigned int [unsigned] [usertype] datarate drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: expected unsigned int [unsigned] [usertype] antenna drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: expected unsigned int [unsigned] [usertype] priority drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: expected unsigned int [unsigned] [usertype] ssi_type drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: expected signed int [signed] [usertype] [explicitly-signed] ssi_signal drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: expected signed int [signed] [usertype] [explicitly-signed] ssi_noise drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: expected unsigned int [unsigned] [usertype] preamble drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: got restricted __be32 [usertype] drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: expected unsigned int [unsigned] [usertype] encoding drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: got restricted __be32 [usertype] Signed-off-by: simran singhal --- v2: -changed commit message drivers/staging/wlan-ng/hfa384x_usb.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index a7ff572..cdf987b 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -3517,14 +3517,14 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, caphdr->hosttime = __cpu_to_be64(jiffies); caphdr->phytype = htonl(4); /* dss_dot11_b */ caphdr->channel = htonl(hw->sniff_channel); - caphdr->datarate = htonl(rxdesc->rate); - caphdr->antenna = htonl(0); /* unknown */ - caphdr->priority = htonl(0); /* unknown */ - caphdr->ssi_type = htonl(3); /* rssi_raw */ - caphdr->ssi_signal = htonl(rxdesc->signal); - caphdr->ssi_noise = htonl(rxdesc->silence); - caphdr->preamble = htonl(0); /* unknown */ - caphdr->encoding = htonl(1); /* cck */ + caphdr->datarate = be32_to_cpu(htonl(rxdesc->rate)); + caphdr->antenna = be32_to_cpu(htonl(0)); /* unknown */ + caphdr->priority = be32_to_cpu(htonl(0)); /* unknown */ + caphdr->ssi_type = be32_to_cpu(htonl(3)); /* rssi_raw */ + caphdr->ssi_signal = be32_to_cpu(htonl(rxdesc->signal)); + caphdr->ssi_noise = be32_to_cpu(htonl(rxdesc->silence)); + caphdr->preamble = be32_to_cpu(htonl(0)); /* unknown */ + caphdr->encoding = be32_to_cpu(htonl(1)); /* cck */ } /* Copy the 802.11 header to the skb -- 2.7.4