mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Todd Brandt <todd.e.brandt@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, todd.e.brandt@intel.com
Subject: Re: [PATCH] ftrace: add ftrace_graph_max_depth kernel parameter
Date: Thu, 2 Mar 2017 19:38:27 -0500	[thread overview]
Message-ID: <20170302193827.6f5ee2eb@gandalf.local.home> (raw)
In-Reply-To: <1488499935-23216-1-git-send-email-todd.e.brandt@linux.intel.com>

On Thu,  2 Mar 2017 16:12:15 -0800
Todd Brandt <todd.e.brandt@linux.intel.com> wrote:

> Early trace callgraphs can be extremely large on systems with
> several seconds of boot time. The max_depth parameter limits how
> deep the graph trace goes and reduces the output size. This
> parameter is the same as the max_graph_depth file in debugfs.

I'll take this with one modification I'll make. s/debugfs/tracefs/
because it's really the tracefs file system now. It just happens to be
automatically mounted in the debugfs file system. But can be by itself
in /sys/kernel/tracing/

-- Steve

> 
> Signed-off-by: Todd Brandt <todd.e.brandt@linux.intel.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 6 ++++++
>  kernel/trace/ftrace.c                           | 9 +++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 986e443..1a8575f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1183,6 +1183,12 @@
>  			functions that can be changed at run time by the
>  			set_graph_notrace file in the debugfs tracing directory.
>  
> +	ftrace_graph_max_depth=<uint>
> +			[FTRACE] Used with the function graph tracer. This is
> +			the max depth it will trace into a function. This value
> +			can be changed at run time by the max_graph_depth file
> +			in the debugfs tracing directory. default: 0 (no limit)
> +
>  	gamecon.map[2|3]=
>  			[HW,JOY] Multisystem joystick and NES/SNES/PSX pad
>  			support via parallel port (up to 5 devices per port)
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 0c06093..fc6b024 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4415,6 +4415,15 @@ static int __init set_graph_notrace_function(char *str)
>  }
>  __setup("ftrace_graph_notrace=", set_graph_notrace_function);
>  
> +static int __init set_graph_max_depth_function(char *str)
> +{
> +	if (!str)
> +		return 0;
> +	fgraph_max_depth = simple_strtoul(str, NULL, 0);
> +	return 1;
> +}
> +__setup("ftrace_graph_max_depth=", set_graph_max_depth_function);
> +
>  static void __init set_ftrace_early_graph(char *buf, int enable)
>  {
>  	int ret;

  reply	other threads:[~2017-03-03  1:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  0:12 Todd Brandt
2017-03-03  0:38 ` Steven Rostedt [this message]
2017-03-03  0:39   ` Steven Rostedt
2017-03-03  0:54     ` Todd Brandt
2017-03-03  1:09       ` Steven Rostedt
2017-03-03  1:35         ` Todd Brandt
2017-03-03 14:31           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302193827.6f5ee2eb@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=todd.e.brandt@intel.com \
    --cc=todd.e.brandt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®