From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbdCBXyn (ORCPT ); Thu, 2 Mar 2017 18:54:43 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:42709 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbdCBXyj (ORCPT ); Thu, 2 Mar 2017 18:54:39 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 165.244.249.23 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Fri, 3 Mar 2017 08:09:11 +0900 From: Byungchul Park To: CC: , , , , , , , , , Subject: Re: [PATCH v3 5/9] fput: Don't reinvent the wheel but use existing llist API Message-ID: <20170302230910.GB28562@X58A-UD3R> References: <1487057190-25191-1-git-send-email-byungchul.park@lge.com> <1487057190-25191-6-git-send-email-byungchul.park@lge.com> <20170214174443.GA13110@redhat.com> MIME-Version: 1.0 In-Reply-To: <20170214174443.GA13110@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/03/03 08:09:24, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/03/03 08:09:24, Serialize complete at 2017/03/03 08:09:24 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 06:44:44PM +0100, Oleg Nesterov wrote: > On 02/14, Byungchul Park wrote: > > > > Although llist provides proper APIs, they are not used. Make them used. > > Reviewed-by: Oleg Nesterov Hello, Al Viro Sorry for my mistake at the previous spin. I should have been more careful. Do you think this still has some problems? > > > Signed-off-by: Byungchul Park > > --- > > fs/file_table.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > > > diff --git a/fs/file_table.c b/fs/file_table.c > > index 6d982b5..3209da2 100644 > > --- a/fs/file_table.c > > +++ b/fs/file_table.c > > @@ -231,12 +231,10 @@ static void __fput(struct file *file) > > static void delayed_fput(struct work_struct *unused) > > { > > struct llist_node *node = llist_del_all(&delayed_fput_list); > > - struct llist_node *next; > > + struct file *f, *t; > > > > - for (; node; node = next) { > > - next = llist_next(node); > > - __fput(llist_entry(node, struct file, f_u.fu_llist)); > > - } > > + llist_for_each_entry_safe(f, t, node, f_u.fu_llist) > > + __fput(f); > > } > > > > static void ____fput(struct callback_head *work) > > @@ -310,7 +308,7 @@ void put_filp(struct file *file) > > } > > > > void __init files_init(void) > > -{ > > +{ > > filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0, > > SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL); > > percpu_counter_init(&nr_files, 0, GFP_KERNEL); > > @@ -329,4 +327,4 @@ void __init files_maxfiles_init(void) > > n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10; > > > > files_stat.max_files = max_t(unsigned long, n, NR_FILE); > > -} > > +} > > -- > > 1.9.1 > >