From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbdCCKYt (ORCPT ); Fri, 3 Mar 2017 05:24:49 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35786 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbdCCKYp (ORCPT ); Fri, 3 Mar 2017 05:24:45 -0500 Date: Fri, 3 Mar 2017 00:21:26 -0600 From: Rob Herring To: Fabrice Gasnier Cc: jic23@kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, benjamin.gaignard@linaro.org, benjamin.gaignard@st.com, linus.walleij@linaro.org Subject: Re: [PATCH v3 1/6] dt-bindings: iio: introduce trigger providers, consumers Message-ID: <20170303062126.5bewa5u6o7wu7sy4@rob-hp-laptop> References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-2-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488300679-3259-2-git-send-email-fabrice.gasnier@st.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 05:51:14PM +0100, Fabrice Gasnier wrote: > Document iio provider and consumer bindings. > > Signed-off-by: Fabrice Gasnier > --- > .../devicetree/bindings/iio/iio-bindings.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/iio-bindings.txt b/Documentation/devicetree/bindings/iio/iio-bindings.txt > index 68d6f8c..01765e9 100644 > --- a/Documentation/devicetree/bindings/iio/iio-bindings.txt > +++ b/Documentation/devicetree/bindings/iio/iio-bindings.txt > @@ -95,3 +95,41 @@ vdd channel is connected to output 0 of the &ref device. > io-channels = <&adc 10>, <&adc 11>; > io-channel-names = "adc1", "adc2"; > }; > + > +==IIO trigger providers== > +Sources of IIO triggers can be represented by any node in the device > +tree. Those nodes are designated as IIO trigger providers. IIO trigger > +consumer uses a phandle and an IIO trigger specifier to connect to an > +IIO trigger provider. > +An IIO trigger specifier is an array of one or more cells identifying > +the IIO trigger output on a device. The length of an IIO trigger > +specifier is defined by the value of a #io-trigger-cells property in > +the IIO trigger provider node. > + > +Required properties: > +#io-trigger-cells: > + Number of cells in an IIO trigger specifier; Typically > + 0 for nodes with a simple IIO trigger output. > + > +Example: > + trig0: interrupt-trigger0 { > + #io-trigger-cells = <0>; > + compatible = "interrupt-trigger"; > + interrupts = <11 0>; > + interrupt-parent = <&gpioa>; > + } > + > +==IIO trigger consumers== > +Required properties: > +- io-triggers: List of phandle representing the IIO trigger specifier. > + > +Optional properties: > +- io-trigger-names : > + List of IIO trigger name strings that matches elements > + in 'io-triggers' list property. > + > +Example: > + some_trigger_consumer { > + io-triggers = <&trig0>; > + io-trigger-names = "mytrig"; > + } I have some reservations about this. We could just as easily add the interrupt directly to the consumer node and use "trigger" for a standard interrupt name. So the question is whether this extra level of indirection is needed? Rob