From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089AbdCDLzV (ORCPT ); Sat, 4 Mar 2017 06:55:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:53113 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdCDLzU (ORCPT ); Sat, 4 Mar 2017 06:55:20 -0500 Date: Sat, 4 Mar 2017 12:55:08 +0100 From: Borislav Petkov To: Baoquan He Cc: tglx@linutronix.de, hpa@zytor.com, mingo@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, keescook@chromium.org, yinghai@kernel.org, anderson@redhat.com, luto@kernel.org, thgarnie@google.com, kuleshovmail@gmail.com Subject: Re: [PATCH v4 1/3] x86: Introduce a new constant KERNEL_MAPPING_SIZE Message-ID: <20170304115508.l4dhlylvkncsow53@pd.tnic> References: <20170303114349.krl6s5qfjmwz3mrg@pd.tnic> <20170303120616.GE18391@x1> <20170303121614.7cgyb6gfhtgmcide@pd.tnic> <20170303125213.GF18391@x1> <20170303131152.GG18391@x1> <20170303142830.pkkvn2iz7dwceei6@pd.tnic> <20170303150751.GH18391@x1> <20170303150857.GI18391@x1> <20170303152319.yensbclmz6uomoyy@pd.tnic> <20170304101037.GA12083@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170304101037.GA12083@x1> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 04, 2017 at 06:10:37PM +0800, Baoquan He wrote: > > BUT(!), don't take my word for it. Rather, do what the maintainers > > propose. Who knows, they might have a much better idea. > > Sorry about that. Just think your words are very convincing on removing > people's doubt if it's risky to shrink kernel modules space to 1G. Will > remove the words mentioning you said it since you don't like it. Didn't > realize that, no offence. No, this is not what I mean at all! I'm saying, I tried to review your patches and I don't like the end result because it adds more complexity. And the reason(s) for it are not persuading me enough to make me say: "yeah, this is a good thing, I want it." But this is only my opinion. That's all. The final decision is in the hands of the x86 maintainers. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --