From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbdCEWus (ORCPT ); Sun, 5 Mar 2017 17:50:48 -0500 Received: from stcim.de ([78.46.73.102]:55801 "EHLO stcim.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398AbdCEWur (ORCPT ); Sun, 5 Mar 2017 17:50:47 -0500 Date: Sun, 5 Mar 2017 23:23:28 +0100 From: Stefan Lengfeld To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Sean Paul , Jani Nikula , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 1/1] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC Message-ID: <20170305222328.GA25089@sill.h.stcim.de> References: <9f67ae4055ab0bc093d7d94e503a0d6d1909d856.1488296169.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9f67ae4055ab0bc093d7d94e503a0d6d1909d856.1488296169.git-series.maxime.ripard@free-electrons.com> X-PGP-Key: https://stefanchrist.eu/personal/Stefan_Lengfeld_0xE44A23B289092311.asc User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Tue, Feb 28, 2017 at 04:36:51PM +0100, Maxime Ripard wrote: > Implement legacy framebuffer ioctl FBIO_WAITFORVSYNC in the generic > framebuffer emulation driver. Legacy framebuffer users like non kms/drm > based OpenGL(ES)/EGL implementations may require the ioctl to > synchronize drawing or buffer flip for double buffering. It is tested on > the i.MX6. > > Signed-off-by: Maxime Ripard > Tested-by: Neil Armstrong > --- > drivers/gpu/drm/drm_fb_helper.c | 68 ++++++++++++++++++++++++++++++++++- > include/drm/drm_fb_helper.h | 12 +++++- > 2 files changed, 79 insertions(+), 1 deletion(-) I have tested the current HEAD of drm-misc-next. It includes this patch and the patch ("drm/fb-helper: Add multi buffer support for cma fbdev"). On my i.MX6 board with HDMI output both patches work as advertised. Multi-buffering with ioctls FBIO_WAITFORVSYNC and FBIOPAN_DISPLAY is possible. Kind Regards Stefan Lengfeld