mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>,
	Robert Richter <rric@kernel.org>,
	oprofile-list@lists.sf.net, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] avr32: Fix build error caused by include file reshuffling
Date: Mon, 6 Mar 2017 08:12:38 +0100	[thread overview]
Message-ID: <20170306071238.GA23974@samfundet.no> (raw)
In-Reply-To: <1488762357-4500-1-git-send-email-linux@roeck-us.net>

Around Sun 05 Mar 2017 17:05:57 -0800 or thereabout, Guenter Roeck wrote:
> Various avr32 builds fail as follows.
> 
> arch/avr32/oprofile/backtrace.c:58: error:
> 	dereferencing pointer to incomplete type
> arch/avr32/oprofile/backtrace.c:60: error:
> 	implicit declaration of function 'user_mode'
> 
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>

> ---
> Please feel free to ignore if av32 is going to be removed.

AVR32 is not going away for 4.11, we started the FYI and review process too
late to make the window.

I think I will push it, to make sure AVR32 leaves the kernel in as good state
as possible.

>  arch/avr32/oprofile/backtrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
> index 75d9ad6f99cf..29cf2f191bfd 100644
> --- a/arch/avr32/oprofile/backtrace.c
> +++ b/arch/avr32/oprofile/backtrace.c
> @@ -14,7 +14,7 @@
>   */
>  
>  #include <linux/oprofile.h>
> -#include <linux/sched.h>
> +#include <linux/ptrace.h>
>  #include <linux/uaccess.h>
>  
>  /* The first two words of each frame on the stack look like this if we have
-- 
mvh
Hans-Christian Noren Egtvedt

  reply	other threads:[~2017-03-06  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06  1:05 Guenter Roeck
2017-03-06  7:12 ` Hans-Christian Noren Egtvedt [this message]
2017-03-07  9:04 ` [tip:core/urgent] " tip-bot for Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170306071238.GA23974@samfundet.no \
    --to=egtvedt@samfundet.no \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@kernel.org \
    --cc=oprofile-list@lists.sf.net \
    --cc=rric@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome