From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbdCFI7H (ORCPT ); Mon, 6 Mar 2017 03:59:07 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:49505 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbdCFI6z (ORCPT ); Mon, 6 Mar 2017 03:58:55 -0500 Date: Mon, 6 Mar 2017 09:58:42 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Geert Uytterhoeven Cc: Richard Genoud , Greg Kroah-Hartman , Geert Uytterhoeven , Nicolas Ferre , Boris Brezillon , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Janusz Uzycki , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls Message-ID: <20170306085842.yijkfpqi3adcedmm@pengutronix.de> References: <20170303142201.16452-1-richard.genoud@gmail.com> <20170303191248.wlwjri55ip2x5pgg@pengutronix.de> <20170303194414.n76tr3oa2mlrzjre@pengutronix.de> <20170304174819.esxhwwbsxzuq3vyc@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert, On Mon, Mar 06, 2017 at 09:49:39AM +0100, Geert Uytterhoeven wrote: > > Given that mctrl-gpio can be useful on legacy platforms, a device could > > silently run without cts-gpio even there. > > On platforms were CONFIG_GPIOLIB=n, this is not true, so the issue is moot. > > All serial drivers using (optional) mctrl-gpio have this in Kconfig: > > select SERIAL_MCTRL_GPIO if GPIOLIB > > So they will use mctrl-gpio when GPIOLIB is enabled. > If GPIOPLIB is disabled, no flow control GPIOs are expected, and the > driver should not break that case. So it all boils down to the question: Is GPIOLIB=n enough to assume no gpio is needed? I'd say it is not. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |