From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: mingo@redhat.com, acme@kernel.org, mhiramat@kernel.org
Cc: brendan.d.gregg@gmail.com, peterz@infradead.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com,
mathieu.poirier@linaro.org, hekuang@huawei.com,
sukadev@linux.vnet.ibm.com, ananth@in.ibm.com,
naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: [PATCH v4 7/7] perf/sdt: Remove stale warning
Date: Mon, 6 Mar 2017 18:43:04 +0530 [thread overview]
Message-ID: <20170306131304.1625-8-ravi.bangoria@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170306131304.1625-1-ravi.bangoria@linux.vnet.ibm.com>
Perf was showing warning if user tries to record sdt event without
creating a probepoint. Now we are allowing direct record on sdt
events, remove this stale warning/hint.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
---
tools/lib/api/fs/tracing_path.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c
index 3e606b9..fa52e67 100644
--- a/tools/lib/api/fs/tracing_path.c
+++ b/tools/lib/api/fs/tracing_path.c
@@ -103,19 +103,10 @@ int tracing_path__strerror_open_tp(int err, char *buf, size_t size,
* - jirka
*/
if (debugfs__configured() || tracefs__configured()) {
- /* sdt markers */
- if (!strncmp(filename, "sdt_", 4)) {
- snprintf(buf, size,
- "Error:\tFile %s/%s not found.\n"
- "Hint:\tSDT event cannot be directly recorded on.\n"
- "\tPlease first use 'perf probe %s:%s' before recording it.\n",
- tracing_events_path, filename, sys, name);
- } else {
- snprintf(buf, size,
- "Error:\tFile %s/%s not found.\n"
- "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
- tracing_events_path, filename);
- }
+ snprintf(buf, size,
+ "Error:\tFile %s/%s not found.\n"
+ "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
+ tracing_events_path, filename);
break;
}
snprintf(buf, size, "%s",
--
2.9.3
prev parent reply other threads:[~2017-03-06 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 13:12 [PATCH v4 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-06 13:12 ` [PATCH v4 1/7] perf/sdt: Introduce util func is_sdt_event() Ravi Bangoria
2017-03-06 13:12 ` [PATCH v4 2/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-08 11:41 ` Masami Hiramatsu
2017-03-06 13:13 ` [PATCH v4 3/7] perf/sdt: Allow recording of existing events Ravi Bangoria
2017-03-06 13:13 ` [PATCH v4 4/7] perf/sdt: Clean uprobe_events when event(out of multiple events) parsing fails Ravi Bangoria
2017-03-06 13:13 ` [PATCH v4 5/7] perf/sdt: Warn when number of events recorded are not equal to cached events Ravi Bangoria
2017-03-06 13:13 ` [PATCH v4 6/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria
2017-03-06 13:13 ` Ravi Bangoria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306131304.1625-8-ravi.bangoria@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hekuang@huawei.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®