From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Doug Ledford <dledford@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Parav Pandit <parav@mellanox.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
David Woodhouse <dwmw2@infradead.org>,
"H . Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>
Subject: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev
Date: Mon, 6 Mar 2017 16:35:48 -0800 [thread overview]
Message-ID: <20170307003549.3872-2-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170307003549.3872-1-bart.vanassche@sandisk.com>
The dma mapping operations of several architectures and also of
several I/O MMU implementations need to translate a struct
device pointer into a struct pci_dev pointer. This translation
is performed by to_pci_dev(). That macro assumes that struct
device is embedded in struct pci_dev. However, that is not the
case for the device structure in struct ib_device. Since that
device structure is passed to DMA mapping operations since kernel
v4.11-rc1, introduce a pointer in struct device to make the
translation from struct device into struct pci_dev more flexible.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Russell King <linux@armlinux.org.uk>
---
drivers/pci/probe.c | 1 +
include/linux/device.h | 5 +++++
include/linux/pci.h | 5 ++++-
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index dfc9a2794141..60d739b59520 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1736,6 +1736,7 @@ struct pci_dev *pci_alloc_dev(struct pci_bus *bus)
INIT_LIST_HEAD(&dev->bus_list);
dev->dev.type = &pci_dev_type;
+ dev->dev.pci_dev = dev;
dev->bus = pci_bus_get(bus);
return dev;
diff --git a/include/linux/device.h b/include/linux/device.h
index 30c4570e928d..c18afd376d2a 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -42,6 +42,7 @@ struct fwnode_handle;
struct iommu_ops;
struct iommu_group;
struct iommu_fwspec;
+struct pci_dev;
struct bus_attribute {
struct attribute attr;
@@ -860,6 +861,9 @@ struct dev_links_info {
* segment limitations.
* @dma_pools: Dma pools (if dma'ble device).
* @dma_mem: Internal for coherent mem override.
+ * @pci_dev: PCI device associated with this device. Used by DMA mapping
+ * operations on architectures that need access to PCI device
+ * members that are not in struct device.
* @cma_area: Contiguous memory area for dma allocations
* @archdata: For arch-specific additions.
* @of_node: Associated device tree node.
@@ -940,6 +944,7 @@ struct device {
struct dma_coherent_mem *dma_mem; /* internal for coherent mem
override */
+ struct pci_dev *pci_dev; /* for DMA mapping operations */
#ifdef CONFIG_DMA_CMA
struct cma *cma_area; /* contiguous memory area for dma
allocations */
diff --git a/include/linux/pci.h b/include/linux/pci.h
index eb3da1a04e6c..eca790eaae20 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -409,7 +409,10 @@ static inline struct pci_dev *pci_physfn(struct pci_dev *dev)
struct pci_dev *pci_alloc_dev(struct pci_bus *bus);
-#define to_pci_dev(n) container_of(n, struct pci_dev, dev)
+static inline struct pci_dev *to_pci_dev(const struct device *dev)
+{
+ return dev->pci_dev;
+}
#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
static inline int pci_channel_offline(struct pci_dev *pdev)
--
2.12.0
next prev parent reply other threads:[~2017-03-07 3:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 0:35 [PATCH 0/2] IB/core fixes for kernel v4.11-rc Bart Van Assche
2017-03-07 0:35 ` Bart Van Assche [this message]
2017-03-07 2:41 ` [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Parav Pandit
2017-03-07 2:44 ` Bart Van Assche
2017-03-07 4:50 ` gregkh
2017-03-07 3:21 ` Parav Pandit
2017-03-07 4:52 ` Greg Kroah-Hartman
2017-03-07 5:08 ` Parav Pandit
2017-03-07 5:13 ` Bart Van Assche
2017-03-07 5:20 ` Parav Pandit
2017-03-07 16:54 ` Bart Van Assche
2017-03-07 17:14 ` gregkh
2017-03-07 18:27 ` Parav Pandit
2017-03-08 1:52 ` Benjamin Herrenschmidt
2017-03-07 0:35 ` [PATCH 2/2] IB/core: Restore I/O MMU, s390 and powerpc support Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307003549.3872-2-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=dledford@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=parav@mellanox.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®