From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755065AbdCGJGc (ORCPT ); Tue, 7 Mar 2017 04:06:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55240 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754644AbdCGJGZ (ORCPT ); Tue, 7 Mar 2017 04:06:25 -0500 Date: Tue, 7 Mar 2017 05:50:51 +0100 From: "gregkh@linuxfoundation.org" To: Bart Van Assche Cc: "parav@mellanox.com" , "dledford@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "sebott@linux.vnet.ibm.com" , "linux@armlinux.org.uk" , "hpa@zytor.com" , "mingo@redhat.com" , "dwmw2@infradead.org" , "bhelgaas@google.com" , "benh@kernel.crashing.org" Subject: Re: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Message-ID: <20170307045051.GB3913@kroah.com> References: <20170307003549.3872-1-bart.vanassche@sandisk.com> <20170307003549.3872-2-bart.vanassche@sandisk.com> <1488854653.2997.1.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488854653.2997.1.camel@sandisk.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 07, 2017 at 02:44:28AM +0000, Bart Van Assche wrote: > On Tue, 2017-03-07 at 02:41 +0000, Parav Pandit wrote: > > Compilation would break when CONFIG_PCI is not defined for some embedded platforms. > > More than that, including specific pci_dev structure pointer in generic structure such as device just doesn't sound right. > > I tested equivalent patch that you sent, but I don't think this is right direction to fix this bug. > > You are welcome to voice your opinion. But unless anyone proposes a better > alternative I propose to proceed with this approach. That's not how development happens. You don't just do "here's a something I came up with, if you don't like it, tough!" If people object, you need to resolve those objections, not ignore them. Especially when you are breaking the build!!! come on now, you know better than this. greg k-h