From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbdCGJzl (ORCPT ); Tue, 7 Mar 2017 04:55:41 -0500 Received: from mga02.intel.com ([134.134.136.20]:33202 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835AbdCGJzf (ORCPT ); Tue, 7 Mar 2017 04:55:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,257,1484035200"; d="scan'208";a="73100597" Date: Tue, 7 Mar 2017 10:30:30 +0200 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: "tpmdd-devel@lists.sourceforge.net" , Jason Gunthorpe , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] tpm/tpm_crb: enter the low power state upon device suspend Message-ID: <20170307083030.a4yq7aqzdf7fnnoo@intel.com> References: <1488758015-12681-1-git-send-email-tomas.winkler@intel.com> <20170306144437.vlrilvo33rxans5t@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B543A553C@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B543A553C@hasmsx108.ger.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 06, 2017 at 06:19:59PM +0000, Winkler, Tomas wrote: > > > > > On Mon, Mar 06, 2017 at 01:53:35AM +0200, Tomas Winkler wrote: > > > This fix enables a platform to enter the idle state (suspend-to-idle) > > > > > > The driver needs to request explicitly go_idle upon completion from > > > the pm suspend handler. > > > The runtime pm is disabled on suspend during prepare state by calling > > > pm_runtime_get_noresume, hence we cannot relay on runtime pm to leave > > > the device in low power state. Symmetrically cmdReady is called upon > > > resume. > > > > > > Signed-off-by: Tomas Winkler > > > > LGTM > > > > Tested-by: Jarkko Sakkinen > > Reviewed-by: Jarkko Sakkinen > > > > PS. What about Fixes? Does this need it? > > No, I don't think this is a regression caused by any patch, rather the pm solution was not complete. > Thanks > Tomas It's in my tree now (and should be in linux-next too soon). /Jarkko