mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tobias Regnery <tobias.regnery@gmail.com>
To: kishon@ti.com, rjui@broadcom.com, jonmason@broadcom.com,
	sbranden@broadcom.com, linux-kernel@vger.kernel.org
Cc: Tobias Regnery <tobias.regnery@gmail.com>
Subject: [PATCH] phy: fix build error in phy-bcm-nsp-usb3 with COMPILE_TEST
Date: Tue,  7 Mar 2017 12:43:52 +0100	[thread overview]
Message-ID: <20170307114352.27385-1-tobias.regnery@gmail.com> (raw)

I see the following build error with COMPILE_TEST on randconfig builds:

divers/built-in.o: In function `nsp_usb3_phy_init':
phy-bcm-nsp-usb3.c:(.text+0x4050): undefined reference to `mdiobus_write'
phy-bcm-nsp-usb3.c:(.text+0x406c): undefined reference to `mdiobus_write'
phy-bcm-nsp-usb3.c:(.text+0x4088): undefined reference to `mdiobus_write'
phy-bcm-nsp-usb3.c:(.text+0x40a4): undefined reference to `mdiobus_write'
phy-bcm-nsp-usb3.c:(.text+0x40c0): undefined reference to `mdiobus_write'
drivers/built-in.o:phy-bcm-nsp-usb3.c:(.text+0x40f2): more undefined references to `mdiobus_write' follow
drivers/built-in.o: In function `mdio_module_init':
phy-bcm-nsp-usb3.c:(.init.text+0x134): undefined reference to `mdio_driver_register'
drivers/built-in.o: In function `mdio_module_exit':
phy-bcm-nsp-usb3.c:(.exit.text+0xcc): undefined reference to `mdio_driver_unregister'

Fix this by adding the correct Kconfig dependency.

Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index dc5277ad1b5a..10e06f0f1dce 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -512,7 +512,7 @@ config PHY_MESON8B_USB2
 
 config PHY_NSP_USB3
 	tristate "Broadcom NorthStar plus USB3 PHY driver"
-	depends on OF && (ARCH_BCM_NSP || COMPILE_TEST)
+	depends on OF && OF_MDIO && (ARCH_BCM_NSP || COMPILE_TEST)
 	select GENERIC_PHY
 	default ARCH_BCM_NSP
 	help
-- 
2.11.0

             reply	other threads:[~2017-03-07 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 11:43 Tobias Regnery [this message]
2017-03-23 21:02 ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307114352.27385-1-tobias.regnery@gmail.com \
    --to=tobias.regnery@gmail.com \
    --cc=jonmason@broadcom.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®