From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933030AbdCGQlR (ORCPT ); Tue, 7 Mar 2017 11:41:17 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:56672 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdCGQiQ (ORCPT ); Tue, 7 Mar 2017 11:38:16 -0500 From: Colin King To: Peter Rosin , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: multiplexer: fix unsigned check with less than zero Date: Tue, 7 Mar 2017 15:06:31 +0000 Message-Id: <20170307150631.31043-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Comparing a size_t with less than zero is always false as size_t is unsigned. The intent of the comparison was to check if the size was -1 (that is, undefined), so use that instead. Detected by CoverityScan, CID#1415278 ("Unsigned compared against 0") Signed-off-by: Colin Ian King --- drivers/iio/multiplexer/iio-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c index 94d40f9b..6c23033 100644 --- a/drivers/iio/multiplexer/iio-mux.c +++ b/drivers/iio/multiplexer/iio-mux.c @@ -61,7 +61,7 @@ static int iio_mux_select(struct mux *mux, int idx) cache = &child->ext_info_cache[i]; - if (cache->size < 0) + if (cache->size == (size_t)-1) continue; ret = iio_write_channel_ext_info(mux->parent, attr, -- 2.10.2