From: Mike Travis <mike.travis@hpe.com>
To: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Don Zickus <dzickus@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Frank Ramsay <frank.ramsay@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
Tony Ernst <tony.ernst@hpe.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] x86/platform: Remove warning message for duplicate NMI handlers
Date: Tue, 07 Mar 2017 15:08:42 -0600 [thread overview]
Message-ID: <20170307210841.730959611@asylum.americas.sgi.com> (raw)
In-Reply-To: <20170307210841.541407747@asylum.americas.sgi.com>
[-- Attachment #1: x86_remove_nmi_warning --]
[-- Type: text/plain, Size: 1342 bytes --]
Remove the WARNING message associated with multiple NMI handlers as
there are at least two that are legitimate. These are the KGDB and the
UV handlers and both want to be called if the NMI has not been claimed
by any other NMI handler.
Use of the UNKNOWN NMI call chain dramatically lowers the NMI call rate
when high frequency NMI tools are in use, notably the perf tools. It is
required on systems that cannot sustain a high NMI call rate without
adversely affecting the system operation.
Signed-off-by: Mike Travis <mike.travis@hpe.com>
Reviewed-by: Dimitri Sivanich <dimitri.sivanich@hpe.com>
---
arch/x86/kernel/nmi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- linux.orig/arch/x86/kernel/nmi.c
+++ linux/arch/x86/kernel/nmi.c
@@ -166,11 +166,9 @@ int __register_nmi_handler(unsigned int
spin_lock_irqsave(&desc->lock, flags);
/*
- * most handlers of type NMI_UNKNOWN never return because
- * they just assume the NMI is theirs. Just a sanity check
- * to manage expectations
+ * Indicate if there are multiple registrations on the
+ * internal NMI handler call chains (SERR and IO_CHECK).
*/
- WARN_ON_ONCE(type == NMI_UNKNOWN && !list_empty(&desc->head));
WARN_ON_ONCE(type == NMI_SERR && !list_empty(&desc->head));
WARN_ON_ONCE(type == NMI_IO_CHECK && !list_empty(&desc->head));
--
next parent reply other threads:[~2017-03-07 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170307210841.541407747@asylum.americas.sgi.com>
2017-03-07 21:08 ` Mike Travis [this message]
2017-03-13 19:48 ` [tip:x86/urgent] " tip-bot for Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307210841.730959611@asylum.americas.sgi.com \
--to=mike.travis@hpe.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dimitri.sivanich@hpe.com \
--cc=dzickus@redhat.com \
--cc=frank.ramsay@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=russ.anderson@hpe.com \
--cc=tglx@linutronix.de \
--cc=tony.ernst@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®