From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569AbdCHICR (ORCPT ); Wed, 8 Mar 2017 03:02:17 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:59801 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbdCHICE (ORCPT ); Wed, 8 Mar 2017 03:02:04 -0500 From: Arnd Bergmann To: Felipe Balbi , Greg Kroah-Hartman Cc: Arnd Bergmann , Nicolas Ferre , Alexandre Belloni , Robert Jarzmik , Joe Perches , Cristian Birsan , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND^2] usb: gadget: udc: atmel: fix debug output Date: Wed, 8 Mar 2017 09:00:15 +0100 Message-Id: <20170308080032.3848369-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ebiv7PWDmYeI1Y+GCmpEv0k3hmg8h5ca3/FZtuyqv7yJ0AFwBc9 IasfoYMIVBxnOYAIQcIhH767FGmT+od9JXzfqalRdByAeeAqHf2AetC4IpgOCcvxQidhNfE K9ue6xHeJ77MvSm9NCuarcwoVidxGiJ3SAlmy3+h5omYn+4fka16q33d2W9zNRK0CDL/ubs lUN16kxav7AIWYG37DzVw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wHKwkpnSUE0=:rG+W86tDsro+IZkimQpcSr PZPifUeQwEAtyCHdxKmrcG7fCHTLX0QscNKypk+/YC44L+H8yMU9vr/q0UPTvAdfgVtKBXOBK t9B+iqb1UcrHGw0z0bAoeW2SN2hShsxDIxFmbpHRGCiwnJZxMX/b/OkvMbZVRs3NpawQrD2a7 NGc18XHXGiq38B0G2b9H+k0v1RcgMEO4e+6O4XyZFiW4e9AOjetjW/LRx2sSX0UYeDOhBBcN/ U1dXU3bkRlPGzr0eriWIkle/G6StURs3dgQGa2nBgd8a9sMhalzF2fxRJJrBL7fPU9ir19dPm dAcI/RQdVC6hZnz2221mtKvC//1t2/6fMN+20xHityVXevnP+dQTRUzVZwyCl4EY4wEJDSiyM Y7E6+hf5b3C+cSpxsYHv+D2ncI5vtNE/9diQemSB7rhI9XwWGjeynDIkhMHq90i73mO2WGvF5 ZsJvkmisDCCk2D9DO8YXODvufqyhx0sBVgLwXDHkrNtiXLQ+8JGMaR1jtu4cZqhnblxtbk8zm r8a3iJqBK8ImK66feAY8A2KLpjMzcdizfV6qRhDgRz7Gn+Gg+zHu6DdkSsKNU0UweNZmBHyyp 2S1NuTsdlPNu9jFapSnifucZ/YE4H3/4z47q87I4tWQZU62gc+7zqcDKSZQ6DRV6UousPV0to ruSv5VavD8BnWhuTwea/sl534fmemWxwd9hj4uJcs/S4gwQI5Qp2BBpe5LJB74vYF9x0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The debug output now contains the wrong variable, as seen from the compiler warning: drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_ep_enable': drivers/usb/gadget/udc/atmel_usba_udc.c:632:550: error: 'ept_cfg' may be used uninitialized in this function [-Werror=maybe-uninitialized] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann Acked-by: Alexandre Belloni Acked-by: Nicolas Ferre --- Originally this broke on Feb 1 and I sent this fix, I resent it after it wasn't applied by Feb 22. This is now one of only two build regressions that made it into 4.11-rc1 that are still broken on linux-next. Please apply drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 11bbce28bc23..2035906b8ced 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { struct usba_ep *ep = to_usba_ep(_ep); struct usba_udc *udc = ep->udc; - unsigned long flags, ept_cfg, maxpacket; + unsigned long flags, maxpacket; unsigned int nr_trans; DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc); @@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) ep->is_in = 0; DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", - ep->ep.name, ept_cfg, maxpacket); + ep->ep.name, ep->ept_cfg, maxpacket); if (usb_endpoint_dir_in(desc)) { ep->is_in = 1; -- 2.9.0