From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbdCHJoH (ORCPT ); Wed, 8 Mar 2017 04:44:07 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:41215 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750752AbdCHJme (ORCPT ); Wed, 8 Mar 2017 04:42:34 -0500 Date: Wed, 8 Mar 2017 16:47:45 +0800 From: Herbert Xu To: Krzysztof Kozlowski Cc: "David S . Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Royce Subject: Re: [PATCH] crypto: s5p-sss - Fix completing crypto request in IRQ handler Message-ID: <20170308084745.GA4883@gondor.apana.org.au> References: <20170305171407.839-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170305171407.839-1-krzk@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 05, 2017 at 07:14:07PM +0200, Krzysztof Kozlowski wrote: > In a regular interrupt handler driver was finishing the crypt/decrypt > request by calling complete on crypto request. This is disallowed since > converting to skcipher in commit b286d8b1a690 ("crypto: skcipher - Add > skcipher walk interface") and causes a warning: > WARNING: CPU: 0 PID: 0 at crypto/skcipher.c:430 skcipher_walk_first+0x13c/0x14c > > The interrupt is marked shared but in fact there are no other users > sharing it. Thus the simplest solution seems to be to just use a > threaded interrupt handler, after converting it to oneshot. > > Signed-off-by: Krzysztof Kozlowski Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt