From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbdCHRWY (ORCPT ); Wed, 8 Mar 2017 12:22:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbdCHRWW (ORCPT ); Wed, 8 Mar 2017 12:22:22 -0500 Date: Wed, 8 Mar 2017 07:06:19 -0600 From: Josh Poimboeuf To: Jiri Kosina Cc: Jessica Yu , Miroslav Benes , Petr Mladek , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: make klp_mutex proper part of API Message-ID: <20170308130619.3ixmcvw6rcy5od32@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 08 Mar 2017 13:06:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 08, 2017 at 10:16:00AM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > klp_mutex is shared between core.c and transition.c, and as such would > rather be properly located in livepatch.h so that we don't have to play > 'extern' games from .c sources. > > This also silences sparse warning (wrongly) suggesting that klp_mutex > should be defined static. include/linux/livepatch.h is the public interface, whereas klp_mutex is a private implementation detail. I think it would be a better fit in kernel/livepatch/core.h (though that file doesn't yet exist). -- Josh