From: Wei Yang <richard.weiyang@gmail.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/mm/numa: trivial fix on typo and error message
Date: Thu, 9 Mar 2017 10:52:55 +0800 [thread overview]
Message-ID: <20170309025255.GA14971@WeideMacBook-Pro.local> (raw)
In-Reply-To: <20170206153529.14614-1-richard.weiyang@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]
Dear masters~
Would you like to share some comments on these two?
On Mon, Feb 06, 2017 at 11:35:28PM +0800, Wei Yang wrote:
>When allocating pg_data in alloc_node_data(), it will try to allocate from
>local node first and then from any node. If it fails at the second trial,
>it means there is not available memory on any node.
>
>This patch fixes the error message and correct one typo.
>
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>---
> arch/x86/mm/numa.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
>index 4366242356c5..3e9110b34147 100644
>--- a/arch/x86/mm/numa.c
>+++ b/arch/x86/mm/numa.c
>@@ -201,8 +201,8 @@ static void __init alloc_node_data(int nid)
> nd_pa = __memblock_alloc_base(nd_size, SMP_CACHE_BYTES,
> MEMBLOCK_ALLOC_ACCESSIBLE);
> if (!nd_pa) {
>- pr_err("Cannot find %zu bytes in node %d\n",
>- nd_size, nid);
>+ pr_err("Cannot find %zu bytes in any node\n",
>+ nd_size);
> return;
> }
> }
>@@ -225,7 +225,7 @@ static void __init alloc_node_data(int nid)
> * numa_cleanup_meminfo - Cleanup a numa_meminfo
> * @mi: numa_meminfo to clean up
> *
>- * Sanitize @mi by merging and removing unncessary memblks. Also check for
>+ * Sanitize @mi by merging and removing unnecessary memblks. Also check for
> * conflicts and clear unused memblks.
> *
> * RETURNS:
>--
>2.11.0
--
Wei Yang
Help you, Help me
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-03-09 2:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 15:35 Wei Yang
2017-02-06 15:35 ` [PATCH 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo() Wei Yang
2017-02-17 14:18 ` Wei Yang
2017-03-13 13:30 ` Borislav Petkov
2017-03-14 2:50 ` Wei Yang
2017-02-28 7:02 ` [PATCH 1/2] x86/mm/numa: trivial fix on typo and error message Wei Yang
2017-03-09 2:52 ` Wei Yang [this message]
2017-03-13 13:00 ` Borislav Petkov
2017-03-14 2:51 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309025255.GA14971@WeideMacBook-Pro.local \
--to=richard.weiyang@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®