From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751611AbdCIE3C (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Mar 2017 23:29:02 -0500
Received: from mail-pf0-f172.google.com ([209.85.192.172]:35268 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750788AbdCIE3B (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Mar 2017 23:29:01 -0500
Date: Thu, 9 Mar 2017 13:29:08 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error
Message-ID: <20170309042908.GA26702@jagdpanzerIV.localdomain>
Reply-To: 20170307055551.GC29458@bbox
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Minchan,

/* I can't https://marc.info/?l=linux-kernel&m=148886631303107 thread
   in my mail box for some reason so the Reply-To message-id may be wrong. */



commit "mm: fix lazyfree BUG_ON check in try_to_unmap_one()"
(mmotm fd07630cbf59bead90046dd3e5cfd891e58e6987)


	if (VM_WARN_ON_ONCE(PageSwapBacked(page) !=
			PageSwapCache(page))) {
	...
	}


does not compile on !CONFIG_DEBUG_VM configs, because VM_WARN_ONCE() is

	#define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e))))



In file included from ./include/linux/mmdebug.h:4:0,
                 from ./include/linux/mm.h:8,
                 from mm/rmap.c:48:
mm/rmap.c: In function ‘try_to_unmap_one’:
./include/linux/bug.h:45:33: error: void value not ignored as it ought to be
 #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e))))
                                 ^
./include/linux/mmdebug.h:49:31: note: in expansion of macro ‘BUILD_BUG_ON_INVALID’
 #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond)
                               ^~~~~~~~~~~~~~~~~~~~
mm/rmap.c:1416:8: note: in expansion of macro ‘VM_WARN_ON_ONCE’
    if (VM_WARN_ON_ONCE(PageSwapBacked(page) !=
        ^~~~~~~~~~~~~~~

	-ss