From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642AbdCIH4k (ORCPT ); Thu, 9 Mar 2017 02:56:40 -0500 Received: from mail.kernel.org ([198.145.29.136]:35004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbdCIH4j (ORCPT ); Thu, 9 Mar 2017 02:56:39 -0500 Date: Thu, 9 Mar 2017 08:56:23 +0100 From: Masami Hiramatsu To: "Naveen N. Rao" Cc: Arnaldo Carvalho de Melo , Ananth N Mavinakayanahalli , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [TRIVIAL PATCH 2/2] kprobes: Convert kprobe_exceptions_notify to use NOKPROBE_SYMBOL Message-Id: <20170309085623.cb9b7db97ecc136e3fada9fd@kernel.org> In-Reply-To: <3f25bf400da5c222cd9b10eec6ded2d6b58209f8.1488991670.git.naveen.n.rao@linux.vnet.ibm.com> References: <3f25bf400da5c222cd9b10eec6ded2d6b58209f8.1488991670.git.naveen.n.rao@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Mar 2017 22:34:15 +0530 "Naveen N. Rao" wrote: > commit fc62d0207ae0 ("kprobes: Introduce weak variant of > kprobe_exceptions_notify()") used the __kprobes annotation to exclude > kprobe_exceptions_notify from being probed. Since NOKPROBE_SYMBOL() is a > better way to do this enabling the symbol to be discovered as being > blacklisted, change over to using NOKPROBE_SYMBOL(). > Oops, yes it should be. Acked-by: Masami Hiramatsu Thanks, > Signed-off-by: Naveen N. Rao > --- > kernel/kprobes.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 699c5bc51a92..b52d952d6d41 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1740,11 +1740,12 @@ void unregister_kprobes(struct kprobe **kps, int num) > } > EXPORT_SYMBOL_GPL(unregister_kprobes); > > -int __weak __kprobes kprobe_exceptions_notify(struct notifier_block *self, > - unsigned long val, void *data) > +int __weak kprobe_exceptions_notify(struct notifier_block *self, > + unsigned long val, void *data) > { > return NOTIFY_DONE; > } > +NOKPROBE_SYMBOL(kprobe_exceptions_notify); > > static struct notifier_block kprobe_exceptions_nb = { > .notifier_call = kprobe_exceptions_notify, > -- > 2.11.1 > -- Masami Hiramatsu