From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752997AbdCIV1O (ORCPT ); Thu, 9 Mar 2017 16:27:14 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35706 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbdCIV1N (ORCPT ); Thu, 9 Mar 2017 16:27:13 -0500 Date: Thu, 9 Mar 2017 13:27:06 -0800 From: Andrew Morton To: Minchan Kim Cc: Sergey Senozhatsky , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: "mm: fix lazyfree BUG_ON check in try_to_unmap_one()" build error Message-Id: <20170309132706.1cb4fc7d2e846923eedf788c@linux-foundation.org> In-Reply-To: <20170309060226.GB854@bbox> References: <20170309042908.GA26702@jagdpanzerIV.localdomain> <20170309060226.GB854@bbox> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Mar 2017 15:02:26 +0900 Minchan Kim wrote: > Sergey reported VM_WARN_ON_ONCE returns void with !CONFIG_DEBUG_VM > so we cannot use it as if's condition unlike WARN_ON. Can we instead fix VM_WARN_ON_ONCE()?