From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932636AbdCIRLC (ORCPT ); Thu, 9 Mar 2017 12:11:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43448 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754695AbdCIRK7 (ORCPT ); Thu, 9 Mar 2017 12:10:59 -0500 Date: Thu, 9 Mar 2017 17:46:19 +0100 From: Greg KH To: simran singhal Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: media: Clean up tests if NULL returned on failure Message-ID: <20170309164619.GB12365@kroah.com> References: <1488567319-25989-1-git-send-email-singhalsimran0@gmail.com> <1488567319-25989-2-git-send-email-singhalsimran0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488567319-25989-2-git-send-email-singhalsimran0@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 04, 2017 at 12:25:18AM +0530, simran singhal wrote: > Some functions like kmalloc/kzalloc return NULL on failure. > When NULL represents failure, !x is commonly used. > > This was done using Coccinelle: > @@ > expression *e; > identifier l1; > @@ > > e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); > ... > - e == NULL > + !e > > Signed-off-by: simran singhal > --- > drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c | 2 +- > drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 4 ++-- > drivers/staging/media/lirc/lirc_zilog.c | 6 +++--- > 3 files changed, 6 insertions(+), 6 deletions(-) Please break this up into one patch per driver. thanks, greg k-h