From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933498AbdCKRgt (ORCPT ); Sat, 11 Mar 2017 12:36:49 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33216 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932877AbdCKRgn (ORCPT ); Sat, 11 Mar 2017 12:36:43 -0500 Date: Sat, 11 Mar 2017 19:29:09 +0200 From: Krzysztof Kozlowski To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 2/8] watchdog: s3c2410: Fix infinite interrupt in soft mode Message-ID: <20170311172909.5brghl4szwijumtt@kozik-lap> References: <20170311172527.16368-1-krzk@kernel.org> <20170311172527.16368-3-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170311172527.16368-3-krzk@kernel.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 11, 2017 at 07:25:21PM +0200, Krzysztof Kozlowski wrote: > In soft (no-reboot) mode, the driver self-pings watchdog upon expiration > of an interrupt. However the interrupt itself was not cleared thus on > first hit, the system enters infinite interrupt handling loop. > > On Odroid U3 (Exynos4412), when booted with s3c2410_wdt.soft_noboot=1 > argument the console is flooded: > # killall -9 watchdog > [ 60.523760] s3c2410-wdt 10060000.watchdog: watchdog timer expired (irq) > [ 60.536744] s3c2410-wdt 10060000.watchdog: watchdog timer expired (irq) > > Fix this by writing something to the WTCLRINT register to clear the > interrupt. The register WTCLRINT however appeared in S3C6410 so a new > watchdog quirk and flavor are needed. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Guenter Roeck > Acked-by: Rob Herring > --- > .../devicetree/bindings/watchdog/samsung-wdt.txt | 9 +++++---- > drivers/watchdog/s3c2410_wdt.c | 21 ++++++++++++++++++--- > 2 files changed, 23 insertions(+), 7 deletions(-) > This can be ignored, already applied. Best regards, Krzysztof