From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932743AbdCKWC5 (ORCPT ); Sat, 11 Mar 2017 17:02:57 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34245 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbdCKWCv (ORCPT ); Sat, 11 Mar 2017 17:02:51 -0500 Date: Sun, 12 Mar 2017 03:32:44 +0530 From: simran singhal To: gregkh@linuxfoundation.org Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH v3] staging: android: Replace strcpy with strlcpy Message-ID: <20170311220244.GA21700@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace strcpy with strlcpy as strcpy does not check for buffer overflow. This is found using Flawfinder. Signed-off-by: simran singhal --- v3: -Correcting the place of the parenthesis and sign drivers/staging/android/ashmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index 7cbad0d..4d9bf48 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c @@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name) if (unlikely(asma->file)) ret = -EINVAL; else - strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name); + strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name, + sizeof(asma->name) - ASHMEM_NAME_PREFIX_LEN); mutex_unlock(&ashmem_mutex); return ret; -- 2.7.4