From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933573AbdCLErD (ORCPT ); Sat, 11 Mar 2017 23:47:03 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33614 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932856AbdCLEqy (ORCPT ); Sat, 11 Mar 2017 23:46:54 -0500 Date: Sun, 12 Mar 2017 05:46:38 +0100 From: Greg Kroah-Hartman To: Arushi Singhal Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Teddy Wang , linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: sm750fb: Improved coding style Message-ID: <20170312044638.GB13797@kroah.com> References: <20170312023402.GA10352@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170312023402.GA10352@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 12, 2017 at 08:04:02AM +0530, Arushi Singhal wrote: > New variables are added to make the code more readable. > Also fixed the checkpatch issue: "Alignment should match open > parenthesis". When you have to say "also" in a commit message, that is a huge red-flag that you need to break a patch up into different parts, as you are doing multiple things. Please do so here. thanks, greg k-h